NVIDIA / modulus-sym

Framework providing pythonic APIs, algorithms and utilities to be used with Modulus core to physics inform model training as well as higher level abstraction for domain experts
https://developer.nvidia.com/modulus
Apache License 2.0
138 stars 56 forks source link

Fix conv fc model #98

Closed ktangsali closed 6 months ago

ktangsali commented 6 months ago

Modulus Pull Request

Description

The order of args for Conv1dFCLayer layer changed during Sym-Core integration PR here: https://github.com/NVIDIA/modulus-sym/pull/62. This caused the values for weight_norm and activation_par to be inverted for Conv1dFCLayer. This PR fixes that issue by making the args explicit.

This also fixes the FNO predictions as ConvFullyConnectedArch model was used for decoder.

Checklist

Dependencies

ktangsali commented 6 months ago

/blossom-ci