NVIDIA / modulus

Open-source deep-learning framework for building, training, and fine-tuning deep learning models using state-of-the-art Physics-ML methods

https://developer.nvidia.com/modulus

Apache License 2.0

903 stars 208 forks source link

condition for the method of scaling in preconditioning EDM #375

Closed yairchn closed 5 months ago

yairchn commented 6 months ago

Modulus Pull Request

Description

The PR is follows up for https://github.com/NVIDIA/modulus/pull/373 with a flag for the choice of scaling that would allow backwards compatibility.

Checklist

[x] I am familiar with the Contributing Guidelines.
[x] New or existing tests cover these changes.
[x] The documentation is up to date with these changes.
[x] The CHANGELOG.md is up to date with these changes.

Dependencies

nbren12 commented 5 months ago

Can this be closed now that #381 has merged?

mnabian commented 5 months ago

Can this be closed now that #381 has merged?

@yairchn could you please confirm?

yairchn commented 5 months ago

@mnabian @nbren12 I'm closing this PR but we should reopen the issue as #381 was reverted see here that was because the current code change had no support for models trained before this change. We need a code change that has some config arg that allows to control this behaviour