NVIDIA / modulus

Open-source deep-learning framework for building, training, and fine-tuning deep learning models using state-of-the-art Physics-ML methods

https://developer.nvidia.com/modulus

Apache License 2.0

943 stars 220 forks source link

Use config file for validation dataset options #449

Closed jleinonen closed 5 months ago

jleinonen commented 5 months ago

Modulus Pull Request

Description

This PR improves the configurability of the validation dataset introduced in https://github.com/NVIDIA/modulus/pull/413:

The validation dataset is now configured under the validation_dataset section of the config file. The validation dataset inherits the config options of the training dataset, except where overridden by validation_dataset.
Remove some hardcoded assumptions about the training dataset. These are replaced by the setup using the config file or moved into the dataset code in cwb.py.

Checklist

[x] I am familiar with the Contributing Guidelines.
[x] New or existing tests cover these changes.
[x] The documentation is up to date with these changes.
[ ] The CHANGELOG.md is up to date with these changes.
[ ] An issue is linked to this pull request.

Dependencies

jleinonen commented 5 months ago

/blossom-ci

jleinonen commented 5 months ago

/blossom-ci

jleinonen commented 5 months ago

/blossom-ci

jleinonen commented 5 months ago

/blossom-ci