NVIDIA / modulus

Open-source deep-learning framework for building, training, and fine-tuning deep learning models using state-of-the-art Physics-ML methods
https://developer.nvidia.com/modulus
Apache License 2.0
797 stars 174 forks source link

🐛[BUG]: CorrDiff: improper default value for `max_norm` #460

Open mnabian opened 2 months ago

mnabian commented 2 months ago

Version

Latest

On which installation method(s) does this occur?

No response

Describe the issue

Traceback (most recent call last): File "/code/mnabian/PRs/out/modulus/examples/generative/corrdiff/train.py", line 341, in main training_loop.training_loop( File "/code/mnabian/PRs/out/modulus/examples/generative/corrdiff/training/training_loop.py", line 294, in training_loop grad_norm = torch.nn.utils.clip_gradnorm( File "/usr/local/lib/python3.10/dist-packages/torch/nn/utils/clip_grad.py", line 40, in clip_gradnorm max_norm = float(max_norm) ValueError: could not convert string to float: 'None'

Minimum reproducible example

No response

Relevant log output

No response

Environment details

No response

mnabian commented 2 months ago

@tge25 could you please fix this?