NVIDIA / modulus

Open-source deep-learning framework for building, training, and fine-tuning deep learning models using state-of-the-art Physics-ML methods
https://developer.nvidia.com/modulus
Apache License 2.0
941 stars 220 forks source link

Fixed indexing error for modulus loss function #484

Closed fresleven closed 3 months ago

fresleven commented 5 months ago

Modulus Pull Request

Description

I forgot to include a commit when pushing the MHD example, which was also supposed to fixe the SWE PINO indexing incorrectly. This is the updated version

https://github.com/NVIDIA/modulus/pull/338#issuecomment-2094897687

Checklist

Dependencies

mnabian commented 4 months ago

/blossom-ci

NickGeneva commented 4 months ago

/blossom-ci

NickGeneva commented 4 months ago

Instead cropping we should consider padding @ktangsali

We should pad the repo with a reflection boundary so we can compute edge derivatives. Makes the domain periodic iirc so the calculation is better.

See: https://github.com/NVIDIA/modulus-sym/blob/main/examples/darcy/darcy_PINO.py#L95

NickGeneva commented 3 months ago

Merged here: https://github.com/NVIDIA/modulus/pull/545

Thanks for the patch.