NVIDIA / modulus

Open-source deep-learning framework for building, training, and fine-tuning deep learning models using state-of-the-art Physics-ML methods

https://developer.nvidia.com/modulus

Apache License 2.0

795 stars 172 forks source link

Support history > 0 in the ERA5 HDF5 datapipe #518

Closed mnabian closed 1 month ago

mnabian commented 1 month ago

Modulus Pull Request

Description

Closes https://github.com/NVIDIA/modulus/issues/519

Checklist

[x] I am familiar with the Contributing Guidelines.
[x] New or existing tests cover these changes.
[x] The documentation is up to date with these changes.
[x] The CHANGELOG.md is up to date with these changes.
[x] An issue is linked to this pull request.

Dependencies

mnabian commented 1 month ago

/blossom-ci

mnabian commented 1 month ago

/blossom-ci

mnabian commented 1 month ago

@Alexey-Kamenev actually it gives this error:

File "/usr/local/lib/python3.10/dist-packages/nvidia/dali/data_node.py", line 202, in process_index
    raise NotImplementedError("Ellipsis in indexing is not implemented")
NotImplementedError: Ellipsis in indexing is not implemented

I'll revert the change in a separate PR

Alexey-Kamenev commented 1 month ago

Oh, it seems like it's a DALI thing as both numpy and PyTorch work just fine with ellipsis.