NVIDIA / modulus

Open-source deep-learning framework for building, training, and fine-tuning deep learning models using state-of-the-art Physics-ML methods

https://developer.nvidia.com/modulus

Apache License 2.0

941 stars 220 forks source link

fix dlwp_healpix constant coupler batch inference #685

Open ivanauyeung opened 1 week ago

ivanauyeung commented 1 week ago

Modulus Pull Request

Description

Fix the bug where dlwp_healpix constant coupler did not support batch coupled inputs for inference

Checklist

[x] I am familiar with the Contributing Guidelines.
[x] New or existing tests cover these changes.
[x] The documentation is up to date with these changes.
[x] The CHANGELOG.md is up to date with these changes.
[ ] An issue is linked to this pull request.

Dependencies

dallasfoster commented 1 week ago

What test covers this change?

yairchn commented 1 week ago

@ivanauyeung
I tested successfully the inference of ensemble forecast with this PR. However, do we know this works in training? have you tested that?

ivanauyeung commented 4 days ago

The function set_coupled_fields in the coupler.py is only used in the inference stage. So these changes will not affect the training. Also, tests are added to cover this function.