NVIDIA / monai-cloud-api

MONAI Cloud API developments for intelligent imaging and learning tools, fostering innovation in medical imaging and AI-driven services.
Apache License 2.0
24 stars 12 forks source link

Improve Auto3DSeg for MLFLow tracking, waiting, and cleanup #43

Closed drbeh closed 7 months ago

drbeh commented 8 months ago

This PR

mingxin-zheng commented 8 months ago

Hi @drbeh , all these notebooks follow a certain format so that the integration test developed by @yiheng-wang-nv will run smoothly. Rearranging functions can potentially break the tests. I'll pass it to @yiheng-wang-nv for the review. Thanks!

drbeh commented 8 months ago

Note: cleanup issue was already addressed in other merged PR, so it is removed after resolving conflicts.

drbeh commented 8 months ago

Hi @drbeh , all these notebooks follow a certain format so that the integration test developed by @yiheng-wang-nv will run smoothly. Rearranging functions can potentially break the tests. I'll pass it to @yiheng-wang-nv for the review. Thanks!

Thanks @mingxin-zheng! Hopefullychanging the place of a helper function doesn't break the integration tests but @yiheng-wang-nv is there any reason not have the helper function at the top?

Cadeww000 commented 7 months ago

✌️😎

yiheng-wang-nv commented 7 months ago

Hi @drbeh , all these notebooks follow a certain format so that the integration test developed by @yiheng-wang-nv will run smoothly. Rearranging functions can potentially break the tests. I'll pass it to @yiheng-wang-nv for the review. Thanks!

Thanks @mingxin-zheng! Hopefullychanging the place of a helper function doesn't break the integration tests but @yiheng-wang-nv is there any reason not have the helper function at the top?

Hi @drbeh , that's the suggestion from @zephyrie . Related comment: https://github.com/NVIDIA/monai-cloud-api/pull/34#discussion_r1454362283

drbeh commented 7 months ago

Thanks @yiheng-wang-nv! I changed back the location of the helper function, so I can merge this.