helm: Fix service name reference in Ingress template

NVIDIA / nim-deploy

A collection of YAML files, Helm Charts, Operator code, and guides to act as an example reference implementation for NVIDIA NIM deployment.

https://build.nvidia.com/

Apache License 2.0

49 stars 17 forks source link

helm: Fix service name reference in Ingress template #12

Closed tmc closed 2 weeks ago

tmc commented 2 weeks ago

The ingress template expects the .serviceType to be suffixed on the service name reference in the hosts portion of the manifest, but the service template does not apply this suffix.

This further cleans up the conditions over the associated kubernetes version checks in the ingress template as the chart currently requires k8s>=1.23 here.

🤙

supertetelman commented 2 weeks ago

Would it be possible for you to re-do this PR with signed commits that conform to our contributions doc?

tmc commented 2 weeks ago

Sorry about that, not sure why I had signed commits off! The contribution guide is a little misleading as it suggests just the 'signed-off-by' content in a commit is sufficient.

I opened a PR pulling in language from the guardrails project here: https://github.com/NVIDIA/nim-deploy/pull/13