search

NVIDIA / nim-deploy

A collection of YAML files, Helm Charts, Operator code, and guides to act as an example reference implementation for NVIDIA NIM deployment.
https://build.nvidia.com/
Apache License 2.0
141 stars 64 forks source link

fix: rename ngc api key;issue #82 #83

Closed sujituk closed 2 months ago

sujituk commented 2 months ago

The variable name "NGC_CLI_API_KEY" needs to be updated to "NGC_API_KEY". Issue here: https://github.com/NVIDIA/nim-deploy/issues/82

https://github.com/NVIDIA/nim-deploy/blob/main/cloud-service-providers/google-cloud/gke/infra/3-config/main.tf line 89: NGC_CLI_API_KEY => NGC_API_KEY

JamesMaki commented 2 months ago

Can you sign this commit with your GPG key?

JamesMaki commented 2 months ago

@sujituk

sujituk commented 2 months ago

@JamesMaki signed using new commit.

JamesMaki commented 2 months ago

The main branch requires all commits to be signed, can you sign the previous one as well?

sujituk commented 2 months ago

@JamesMaki I've another incoming PR for GCS Caching. Okay to include these changes in that PR and close this?

JamesMaki commented 2 months ago

Sure, that works. Thank you!

sujituk commented 2 months ago

Included in https://github.com/NVIDIA/nim-deploy/pull/90