Search for nvdisasm in the conda environment / `CUDA_HOME` / default CUDA install location in addition to the path

NVIDIA / numba-cuda

BSD 2-Clause "Simplified" License

24 stars 7 forks source link

Open brycelelbach opened 2 months ago

brycelelbach commented 2 months ago

Fixes #9.

I'm not sure how good the unit test coverage is for this, or the other path search functionality. Ideally we'd need contained tests that cover:

Conda
A default CUDA install (e.g. /usr/local/cuda):
- With the full toolkit.
- With only libraries, no nvdisasm etc.
- With only libraries, but nvdisasm in PATH.
CUDA_HOME:
- With the full toolkit.
- With only libraries, no nvdisasm etc.
- With only libraries, but nvdisasm in PATH.

copy-pr-bot[bot] commented 1 month ago

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

gmarkall commented 1 month ago

Just merged develop and pushed so that CI can run on this PR.

gmarkall commented 1 month ago

/ok to test

gmarkall commented 1 month ago

Looks like there's some issue with nvdisasm tests with this PR - I haven't looked into it yet, but let me know if any guidance would be helpful.