NVIDIA / numba-cuda

BSD 2-Clause "Simplified" License
24 stars 7 forks source link

Replace scikit-build-core / CMake with setuptools #16

Closed gmarkall closed 1 month ago

gmarkall commented 1 month ago

Using scikit-build-core and CMake was overkill for copying two files into site-packages. This change replaces them with setuptools, and also modifies some of the package names to use a dash (i.e. numba-cuda) which I think is more "standard" in the places in which I've done it here.

Manual testing suggests that the packages built before and after this change are identical, with a couple of small exceptions:

Many thanks to @vyasr for pointing me to the solution to copy files to site-packages with setuptools, as used in rapids-dask-dependency.

gmarkall commented 1 month ago

My review has no power here, but this LGTM.

On the contrary, I would not merge it without your approval :slightly_smiling_face: