search

NVIDIA / nvbench

CUDA Kernel Benchmarking Library
Apache License 2.0
452 stars 61 forks source link

Bazel build rules #120

Open mmcloughlin opened 1 year ago

mmcloughlin commented 1 year ago

We are planning on using nvbench in our bazel monorepo. This will involve writing bazel build rules.

It would be awesome if nvbench had the build rules in the repository itself so they keep in sync, and are verified by your CI systems. Is that something you'd consider adding? Alternatively, if we get it working would you consider accepting a PR that adds them?

alliepiper commented 1 year ago

Sure! We'll take a PR, but this will be an entirely community-supported feature.

mmcloughlin commented 1 year ago

Sure! We'll take a PR, but this will be an entirely community-supported feature.

Okay, cool. If the repository contained bazel build rules they would need to be enforced by CI, or they would no doubt get stale quickly. At the moment I'm not sure how your CI runs (see #110), but would it be possible to add a bazel build step to your CI too?

mmcloughlin commented 1 year ago

entirely community-supported feature

To clarify the point I was trying to make in my last post, I think these rules being the repository would only make sense if their correctness was maintained by CI. But then they become your problem too, not just a community supported feature.

alliepiper commented 1 year ago

We're currently working on setting up some new CI infrastructure for this a some related NVIDIA opensource projects, so it would be a little while before we could set something like that.

Our projects have been primarily CMake, I'm not sure if we'd be able to test other build systems in CI. @jrhemstad, thoughts?

alliepiper commented 1 year ago

We discussed this a bit offline. We'll take a PR to get things working now, and once we have the new CI ready we can look into adding it. As long as it's a reasonable amount of work to get a Bazel build running, we can probably add coverage for it when the time comes.

Mr-Nineteen commented 7 months ago

When will it be supported?