search

NVIDIA / nvidia-docker

Build and run Docker containers leveraging NVIDIA GPUs
Apache License 2.0
17.21k stars 2.03k forks source link

NVIDIA Container Toolkit: wrong version number of OS in nvidia-docker.list for Ubuntu 20.04 #1603

Closed DB-MaxKaiser closed 2 years ago

DB-MaxKaiser commented 2 years ago

Sorry, pretty similar to https://github.com/NVIDIA/nvidia-container-toolkit/issues/282 and unable to delete my issue.

Issue

Under https://docs.nvidia.com/datacenter/cloud-native/container-toolkit/install-guide.html#docker, one can find a command for an automatic, OS distribution selective integration of the repository for the NVIDIA Container Toolkit:

$ distribution=$(. /etc/os-release;echo $ID$VERSION_ID)  && curl -s -L https://nvidia.github.io/nvidia-docker/gpgkey | sudo apt-key add -  && curl -s -L https://nvidia.github.io/nvidia-docker/$distribution/nvidia-docker.list | sudo tee /etc/apt/sources.list.d/nvidia-docker.list

Running it under Ubuntu 20.04 would download from https://nvidia.github.io/nvidia-docker/ubuntu20.04/nvidia-docker.list a "nvidia-docker.list" with wrong OS version strings It contains:

deb https://nvidia.github.io/libnvidia-container/stable/ubuntu18.04/$(ARCH) /
#deb https://nvidia.github.io/libnvidia-container/experimental/ubuntu18.04/$(ARCH) /
deb https://nvidia.github.io/nvidia-container-runtime/stable/ubuntu18.04/$(ARCH) /
#deb https://nvidia.github.io/nvidia-container-runtime/experimental/ubuntu18.04/$(ARCH) /
deb https://nvidia.github.io/nvidia-docker/ubuntu18.04/$(ARCH) /

Manual Fix

Adjusting the version number strings in the list-file:

$ sudo nano /etc/apt/sources.list.d/nvidia-docker.list 

   deb https://nvidia.github.io/libnvidia-container/stable/ubuntu20.04/$(ARCH) /
   #deb https://nvidia.github.io/libnvidia-container/experimental/ubuntu20.04/$(ARCH) /
   deb https://nvidia.github.io/nvidia-container-runtime/stable/ubuntu20.04/$(ARCH) /
   #deb https://nvidia.github.io/nvidia-container-runtime/experimental/ubuntu20.04/$(ARCH) /
   deb https://nvidia.github.io/nvidia-docker/ubuntu20.04/$(ARCH) /

The adjusted list-file still works: Calling

$  apt-cache policy nvidia-docker2

would return "Candidate: 2.8.0-1", which is the latest stable version. An installation runs through, too.

Proposed Fix

The present "nvidia-docker.list" might be working. Still it can be confusing. For reasons of consistency, you might want to update https://nvidia.github.io/nvidia-docker/ubuntu20.04 in your git repository by the correct version number strings.

elezar commented 2 years ago

Hi @DB-Kaiser. The behaviour of having the ubuntu18.04 string in the repo list is the expected behaviour. We do agree that this could lead to confusion and could address this in future. For the time being, however, the mechanism we use to publish these packages does not lend itself well to updating these lists for the distributions individually.

Would a note in the installation documentation be sufficient for the time being?

DB-MaxKaiser commented 2 years ago

Hello Mr. Lezar,

Thank you for getting back to me! I understand that a deep rework of your build-toolchain is no option here. And it is OK this way as long as it works. Therefore, a note in the installation documentation would be perfectly fine. Thanks again for your efforts!

Kind regards, Max Kaiser

Von: Evan Lezar @.> Gesendet: Mittwoch, 9. Februar 2022 13:04 An: NVIDIA/nvidia-docker @.> Cc: Max Kaiser @.>; Mention @.> Betreff: Re: [NVIDIA/nvidia-docker] NVIDIA Container Toolkit: wrong version number of OS in nvidia-docker.list for Ubuntu 20.04 (Issue NVIDIA/nvidia-docker#1603)

Sie erhalten nicht oft E-Mail von @.***". Weitere Informationen, warum dies wichtig isthttp://aka.ms/LearnAboutSenderIdentification

Hi @DB-Kaiserhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FDB-Kaiser&data=04%7C01%7Cmax.kaiser%40deutschebahn.com%7C7d05b3e206cf46dc9f1008d9ebc44bae%7Ca1a72d9c49e64f6d9af65aafa1183bfd%7C0%7C0%7C637800050583526540%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=ET23TWOyzjsNhirbjdRoje4ICbR%2FXyjxJWmHOW2VNnA%3D&reserved=0. The behaviour of having the ubuntu18.04 string in the repo list is the expected behaviour. We do agree that this could lead to confusion and could address this in future. For the time being, however, the mechanism we use to publish these packages does not lend itself well to updating these lists for the distributions individually.

Would a note in the installation documentation be sufficient for the time being?

- Reply to this email directly, view it on GitHubhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FNVIDIA%2Fnvidia-docker%2Fissues%2F1603%23issuecomment-1033689172&data=04%7C01%7Cmax.kaiser%40deutschebahn.com%7C7d05b3e206cf46dc9f1008d9ebc44bae%7Ca1a72d9c49e64f6d9af65aafa1183bfd%7C0%7C0%7C637800050583526540%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=59aJX6MkG0CXkAeSS2SmiJxaoc2zLXyJP9X4uZ98Nsw%3D&reserved=0, or unsubscribehttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAOJQL577K2AEUZQ5JUZL5KLU2JJ37ANCNFSM5NO3P4MA&data=04%7C01%7Cmax.kaiser%40deutschebahn.com%7C7d05b3e206cf46dc9f1008d9ebc44bae%7Ca1a72d9c49e64f6d9af65aafa1183bfd%7C0%7C0%7C637800050583526540%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=OsA6roeEq5lwZGUCO0usuxYkLDv69XJ%2BUgYdJIOQ7Rs%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7Cmax.kaiser%40deutschebahn.com%7C7d05b3e206cf46dc9f1008d9ebc44bae%7Ca1a72d9c49e64f6d9af65aafa1183bfd%7C0%7C0%7C637800050583526540%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=qTutSIyBB0ny%2BkoUs0tmujfamiOTnlER2iwh%2BSCOSAo%3D&reserved=0 or Androidhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7Cmax.kaiser%40deutschebahn.com%7C7d05b3e206cf46dc9f1008d9ebc44bae%7Ca1a72d9c49e64f6d9af65aafa1183bfd%7C0%7C0%7C637800050583526540%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=hNgO6kLJYcvp9HASEC3KyZyJdoC1o1zN%2B6QvSP2SG0s%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.***>

Pflichtangaben anzeigenhttp://www.deutschebahn.com/pflichtangaben/20220204

N?here Informationen zur Datenverarbeitung im DB-Konzern finden Sie hier: http://www.deutschebahn.com/de/konzern/datenschutz