search

NVIDIA / nvidia-settings

NVIDIA driver control panel
http://www.nvidia.com/object/unix.html
GNU General Public License v2.0
292 stars 75 forks source link

Ensure wayland pkg-config dependencies are propagated #86

Closed Kiskae closed 1 year ago

Kiskae commented 2 years ago

missing pkg-config args meant the libnvidia-wayland-client.so helper library never gets built.

sl1pkn07 commented 1 year ago

mmm is builded, but not linked or use the correct cflags

maybe is intentional?

Kiskae commented 1 year ago

If its intentional then its weird that the calls to pkg-config are still there, since they don't actually do anything in their current form.

sl1pkn07 commented 1 year ago

i have builded done without this PR (with wayland support enabled), and applied i see no changes (ldd includes) so...

Kiskae commented 1 year ago

So it does. At some point it didn't build the wayland client but it seems to have been fixed at some point. I'll leave this PR open since the pkg-config calls are either redundant or result in missing dependencies for some weird environment, even if the build works properly.

sl1pkn07 commented 1 year ago

gtk2/3 ldflags set -Wl,--no-as-needed maybe need also set in this?

greetings

Kiskae commented 1 year ago

Looks like these changes were applied in https://github.com/NVIDIA/nvidia-settings/commit/39c3e28e84f3ffb034abaf1ae92dbb570c207d05