search

NVIDIA / open-gpu-kernel-modules

NVIDIA Linux open GPU kernel module source
Other
15.05k stars 1.25k forks source link

User Linter and CI #27

Open 6543 opened 2 years ago

6543 commented 2 years ago

It would be a good practice to enforce linter to detect/avoid things like pointed out in #24

6543 commented 2 years ago

31 or #108 ?

mmaneetsingh commented 2 years ago

Consolidating comment from @ghtesting2020 (https://github.com/NVIDIA/open-gpu-kernel-modules/issues/115): I'm seeing dozens of tickets that could be avoided if Nvidia used a linter in their own internal dev environment. GitHub Actions could also be implemented to autocheck code for compliance, security issues, quality, etc. At my work we use cppcheck for static code analysis and it's been amazing so far. SonarQube/Lint is also an option as well as being open source/free.

sTiKyt commented 2 years ago

Consolidating comment from @ghtesting2020 (here): I'm seeing dozens of tickets that could be avoided if Nvidia used a linter in their own internal dev environment. GitHub Actions could also be implemented to autocheck code for compliance, security issues, quality, etc. At my work we use cppcheck for static code analysis and it's been amazing so far. SonarQube/Lint is also an option as well as being open source/free.

You may have forgotten to add link to "(here)" section? I may be getting it wrong

mmaneetsingh commented 2 years ago

updated, thanks for pointing out.