ENROOT_ROOTFS_WRITABLE not honored

NVIDIA / pyxis

Container plugin for Slurm Workload Manager

Apache License 2.0

273 stars 31 forks source link

ENROOT_ROOTFS_WRITABLE not honored #19

Closed coolinger closed 4 years ago

coolinger commented 4 years ago

The container launched by pyxis always has the container root filesystem mounted writable, even if ENROOT_ROOTFS_WRITABLE is set to "no" in /etc/enroot/enroot.conf.

It would be nice if there was an option to explicitly mount it rw, or use the defaults instead of the hardcoded "--rw" in pyxis_slurmstepd.c

Regards Quirin

flx42 commented 4 years ago

You are right, this was an oversight. I have now done the change.

flx42 commented 4 years ago

Thanks for reporting!