search

NVIDIA / pyxis

Container plugin for Slurm Workload Manager
Apache License 2.0
273 stars 31 forks source link

pyxis: unable to use locally built and tagged images #23

Closed sfeltman closed 3 years ago

sfeltman commented 4 years ago

Pyxis is prepending "docker://" to image names given to the --container-image argument. This doesn't allow for local images built and tagged before the call to srun. While ultimately the solution for me will be to use a registry, it would be nice to allow explicit use of "dockerd://imagetag" as an argument as enroot seems to.

Thanks

flx42 commented 4 years ago

I don't think we're going to implement this directly in pyxis, sorry. Instead, you can use enroot import and pass the squashfs file to pyxis:

$  enroot import -o test.sqsh dockerd://flx42/test
$ srun --container-image ./test.sqsh

We don't have the docker daemon on our clusters, and it doesn't really make sense for a cluster: across nodes, each docker daemon will have a different state. Unless you are planning to use docker build then use pyxis on a single node only?

Averylamp commented 1 year ago

Hi @flx42, I saw that the usage of dockerd with pyxis has come up in a couple issues. I was curious if there were plans to support it? Thanks!

flx42 commented 1 year ago

Not for now, it's not really complicated to add but it's not a feature we would use in any of our clusters.

Averylamp commented 1 year ago

Would you accept a PR that adds it?

flx42 commented 1 year ago

Not right now, but I will consider that for a later release, thanks!

flx42 commented 1 year ago

Finally added support in https://github.com/NVIDIA/pyxis/commit/a72ec8d53b317674e0841c11a66d6eb6b6b814ac

Averylamp commented 1 year ago

Finally added support in a72ec8d

Thank you!