NVIDIA / pyxis

Container plugin for Slurm Workload Manager
Apache License 2.0
273 stars 31 forks source link

Support for private registries? #34

Closed elgalu closed 3 years ago

elgalu commented 3 years ago

Does pyxis support token protected private docker registries?

By reading https://github.com/NVIDIA/pyxis/issues/8#issuecomment-560544044 it would seem no.

microbioticajon commented 3 years ago

Interesting timing, I am researching if pyxis will work with private AWS ECR repositories via the Amazon ECR Docker Credential Helper. Further information regarding private repositories would be helpful.

lukeyeager commented 3 years ago

I'd start by reading this section of the enroot documentation: https://github.com/NVIDIA/enroot/blob/v3.2.0/doc/cmd/import.md#description

flx42 commented 3 years ago

It does work for multiple private repositories we have tested. Please test with enroot like @lukeyeager mentioned, and if it doesn't work let us know (by filing an issue against enroot if you see the problem with just enroot).

3XX0 commented 3 years ago

@microbioticajon we didn't test ECR but if I had to guess it's probably something like this:

machine <ACCOUNT>.dkr.ecr.<REGION>.amazonaws.com login AWS password $(aws ecr get-login-password)

flx42 commented 3 years ago

Please reopen if you see a problem :)