search

NVIDIA / pyxis

Container plugin for Slurm Workload Manager
Apache License 2.0
282 stars 31 forks source link

Should `--no-container-remap-root` be equivalent to `ENROOT_REMAP_ROOT no` ? #64

Closed vfdev-5 closed 3 years ago

vfdev-5 commented 3 years ago

Question: if we set in enroot.conf : ENROOT_REMAP_ROOT no should it be equivalent to --no-container-remap-root option in pyxis and if we call:

srun  --container-image=mycontainer.sqsh whoami
> user

and the same as 

srun  --container-image=mycontainer.sqsh --no-container-remap-root whoami
> user

?

Currently (on master), this is not true:

srun  --container-image=mycontainer.sqsh whoami
> root

and

srun  --container-image=mycontainer.sqsh --no-container-remap-root whoami
> user

Thanks

flx42 commented 3 years ago

Good catch, it used to be that pyxis had a different code path internally depending on whether root remapping needed to be done, and there was no way to query the enroot config so that's why there is remap_root in the pyxis configuration file.

But this should not be needed anymore, pyxis should now be able to just use the enroot default when --container-remap-root and --no-container-remap-root are not set. I will make the change.

flx42 commented 3 years ago

Should work fine now, please test if you can :)