search

NVIDIA / spark-rapids-benchmarks

Spark RAPIDS Benchmarks – benchmark sets and utilities for the RAPIDS Accelerator for Apache Spark
Apache License 2.0
36 stars 27 forks source link

[Bug] Failed to build twice in nds/tpcds-gen #157

Closed GaryShen2008 closed 1 year ago

GaryShen2008 commented 1 year ago

Reproduce steps:

  1. Download the tpcds-tools and set TPCDS_HOME.
  2. Go into nds/tpcds-gen and run "make"
  3. Run "make" again after the first building.

The second "make" failed as below:

which already exists! Assume -R? [n] Apply anyway? [n] Skipping patch. 1 out of 1 hunk ignored make: *** [Makefile:17: target/tools/dsdgen] Error 1

Expectation: The Makefile in nds/tpcds-gen should handle the patched source code correctly, so that not fail when the source code has been patched before.

gerashegalov commented 1 year ago

I've seen this and I thought I addressed it here https://github.com/NVIDIA/spark-rapids-benchmarks/pull/133/files#diff-6948b84a535d1ddbeb65d37295a6fc1058117aa6ffe17a33f8625149f36c5237R16-R17

GaryShen2008 commented 1 year ago

Thanks, Gera. I was not aware of that. Close this bug.