search

NVIDIA / spark-rapids-jni

RAPIDS Accelerator JNI For Apache Spark
Apache License 2.0
36 stars 64 forks source link

Add support for hive hash #2171

Closed firestarman closed 3 months ago

firestarman commented 3 months ago

contribute to https://github.com/NVIDIA/spark-rapids-jni/issues/2096

This PR adds the support for Hive hash with the basic types. The supported types list is [bool, byte, short, int, long, string, date, timestamp, float, double].

firestarman commented 3 months ago

build

firestarman commented 3 months ago

Hi @mythrocks , could you help review it ? Thx.

firestarman commented 3 months ago

build

firestarman commented 3 months ago

build

ttnghia commented 3 months ago

CI fails due to including the old header (hash.cuh) in tests/hash.cpp. Need to change to hash.hpp.

firestarman commented 3 months ago

build

firestarman commented 3 months ago

CI fails due to including the old header (hash.cuh) in tests/hash.cpp. Need to change to hash.hpp.

Yeah, made a fix

firestarman commented 3 months ago

Really appreciate your quick reviews. @ttnghia @mythrocks . Learnt a lot on cudf coding.