search

NVIDIA / spark-rapids-jni

RAPIDS Accelerator JNI For Apache Spark
Apache License 2.0
41 stars 66 forks source link

[BUG] CI does not catch missing copyright or license on new files #2571

Closed jlowe closed 6 days ago

jlowe commented 2 weeks ago

One of the CI runs on #2559 should have failed due to a missing copyright and license header on a source file but it did not. We should use something like apache-rat-plugin to catch this error of omission in CI.

mattahrens commented 2 weeks ago

@pxLi can this be addressed with the common build repo?

pxLi commented 2 weeks ago

@pxLi can this be addressed with the common build repo?

Yes, this could be a good shared action usage to verify the license header change.

I will create another ticket in common repo.

cc @YanxuanLiu https://github.com/NVIDIA/spark-rapids-common/issues/9 please help consider scenarios for multiple projects, thanks