NVIDIA / spark-rapids-tools

User tools for Spark RAPIDS
Apache License 2.0
44 stars 34 forks source link

Split JobStageAggTaskMetrics file into two different files #1044

Closed parthosa closed 1 month ago

parthosa commented 1 month ago

Issue: #1017

This PR splits the job_+_stage_level_aggregated_task_metrics.csv generated by the Profiling tool into two separate files. We have fixed this in Qualification Tool (#1000).

Changes

Note

Not Covered

parthosa commented 1 month ago

@amahussein Thanks Ahmed. We are targeting this PR to a staging branch.

After this, I will submit a follow up PR with changes only in the prediction code targeted to this staging branch.

This would make it easier for Lee/Eric to review the changes in prediction code only.

We can provide them the relevant changes in tools at an abstraction.

Once the follow up PR is merged on staging branch, we can then merge the staging branch to dev. Thus, we should be able to not fallback to legacy speedups.

parthosa commented 1 month ago

@amahussein The changes in prediction code are very minor. Hence I preferred making this change before.