Closed cindyyuanjiang closed 4 weeks ago
thanks for fixing this, it would be nice to add the new fixed output to the description.
This is likely a separate issue, but it seems odd ot me that the tool doesn't fail if we pass in a bad parameter for --platform... For instance if I pass in databricks-aws-r4 it happily goes along and just changes it to be something else -
24/06/07 07:43:57 INFO PlatformFactory: Using platform: databricks-aws
I would have expected this to error out so user knows they are not going to get what they expect. @mattahrens @amahussein thoughts on this, if you agree we can file a separate issue.
This is likely a separate issue, but it seems odd ot me that the tool doesn't fail if we pass in a bad parameter for --platform... For instance if I pass in databricks-aws-r4 it happily goes along and just changes it to be something else -
24/06/07 07:43:57 INFO PlatformFactory: Using platform: databricks-aws
I would have expected this to error out so user knows they are not going to get what they expect. @mattahrens @amahussein thoughts on this, if you agree we can file a separate issue.
Yes, we can file a separate issue for that
Fixes https://github.com/NVIDIA/spark-rapids-tools/issues/1030
Problem Java Qual tool Autotuner outputs inconsistent results when GPU device is not provided in worker info file (
--worker-info
) and platform is set todatabricks-aws-t4
:- GPU device is missing. Setting default to a10G.
--conf spark.rapids.sql.concurrentGpuTasks=2
-> indicates GPU is T4Changes
Testing
In
WORKER_INFO_FILE
: