search

NVIDIA / spark-rapids-tools

User tools for Spark RAPIDS
Apache License 2.0
53 stars 37 forks source link

[BUG] Onprem user qualification tool throws FileNotFoundError #1270

Closed cindyyuanjiang closed 2 months ago

cindyyuanjiang commented 2 months ago

Describe the bug

2024-08-08 15:29:45,510 ERROR root: Qualification. Raised an error in phase [Initialization]
Traceback (most recent call last):
  File "xxxxxx/spark-rapids-tools/user_tools/src/spark_rapids_pytools/common/prop_manager.py", line 94, in __open_json_file
    with open(self.prop_arg, 'r', encoding='utf-8') as json_file:
FileNotFoundError: [Errno 2] No such file or directory: 'xxxxxx/spark-rapids-tools/user_tools/src/spark_rapids_pytools/resources/onprem-instance-catalog.json'

Steps/Code to reproduce bug spark_rapids qualification --eventlogs <my-local-eventlog> -v

parthosa commented 2 months ago

Thanks @cindyyuanjiang for filing this. I also encountered this bug while adding cluster recommendation for OnPrem and Dataproc. I have fixed this in #1265. Could you check if anything else needs to be done?

cindyyuanjiang commented 2 months ago

Thanks @parthosa! I just quickly went over the changes. It looked good to me. Could you link you PR for fixing this issue? cc: @nartal1

parthosa commented 2 months ago

Updated the PR for fixing this issue.