Remove estimated GPU duration from qualification output

NVIDIA / spark-rapids-tools

User tools for Spark RAPIDS

Apache License 2.0

56 stars 37 forks source link

Remove estimated GPU duration from qualification output #1412

Closed amahussein closed 2 weeks ago

amahussein commented 2 weeks ago

Signed-off-by: Ahmed Hussein ahussein@nvidia.com

Fixes #1411

Removes two columns from the core qualification's output Estimated GPU Duration and Estimated GPU Time Saved from 2 files rapids_4_spark_qualification_output.csv and rapids_4_spark_qualification_output_persql.csv

This PR also removes the unused fields in EstimatedAppInfo since it is becoming dead code.
Updated the unit tests

amahussein commented 2 weeks ago

Found that I mistakenly removed the quotes from the CSV files

amahussein commented 2 weeks ago

Thanks @amahussein. QQ: How do we update the expectation files beside running the tools for each of them? Do we have a script to update the expectation files?

Thanks @parthosa Yes, I wrote a script some time ago core/src/test/resources/dev/generate-qualification-test-results.sh. I did not use it this time because I could do the fixes manually.