search

NVIDIA / spark-rapids-tools

User tools for Spark RAPIDS
Apache License 2.0
56 stars 37 forks source link

Remove custom-speedup module from user-tools #1425

Closed amahussein closed 1 week ago

amahussein commented 1 week ago

Signed-off-by: Ahmed Hussein (amahussein) a@ahussein.me

Contributes to #1221

This PR remove the python scripts that used to generate custom speedup factors. The scripts are dead since the tools migrated to XGBoost estimates.

mattahrens commented 1 week ago

Approved, but one question -- is the custom speedup factor file option being removed by another PR? https://github.com/NVIDIA/spark-rapids-tools/blob/dev/core/src/main/scala/com/nvidia/spark/rapids/tool/qualification/QualificationArgs.scala#L184-L188

amahussein commented 1 week ago

Approved, but one question -- is the custom speedup factor file option being removed by another PR? https://github.com/NVIDIA/spark-rapids-tools/blob/dev/core/src/main/scala/com/nvidia/spark/rapids/tool/qualification/QualificationArgs.scala#L184-L188

Yes, there is another task to remove deadcode from scala https://github.com/NVIDIA/spark-rapids-tools/issues/1343