[FEA] The qualification HTML only shows the SPEEDUPS GPU acceleration in its output

kuhushukla commented 4 months ago

Describe the bug The qualification output's html files show speedup numbers based on SPEEDUPS algorithm even if --estimation model is set to XGBOOST

Steps/Code to reproduce bug Run qual tool with --estimation-model set to xgboost, compare the number seen in html file with the speed up values in the qualification_summary.csv

Expected behavior Show all factors or at least the speedup factor that comes from the specified estimation model

Environment details (please complete the following information)

Any . I saw it in databricks azure

amahussein commented 4 months ago

Marking this as a feature request since the UI HTML is submodule of the core tools. This implies that it does not support the TCL or the Cost savings. In order to mirror the CLI's output, the UI-HTML code generation needs to be moved to the user-tools module and then rebuild it to match the output folder.

We have 2 existing issues already about the same things:

[FEA] Add savings estimates to the UI summary report
There is another issue to extend the HTML to mirror the core tools output instead. #692 [BUG] Sync-up HTML report to mirror the CSV files

amahussein commented 1 week ago

UI is being removed as per https://github.com/NVIDIA/spark-rapids-tools/issues/1310 CC: @kuhushukla

NVIDIA / spark-rapids-tools

[FEA] The qualification HTML only shows the SPEEDUPS GPU acceleration in its output #986