thirtiseven
commented
1 month ago Specific cases in Spark UT that fails (commented):
test("SPARK-35112: Cast string to day-time interval2") {
// checkEvaluation(cast(Literal.create("0"), DayTimeIntervalType()), 0L)
// checkEvaluation(cast(Literal.create("0 0:0:0"), DayTimeIntervalType()), 0L)
// checkEvaluation(cast(Literal.create(" interval '0 0:0:0' Day TO second "),
// DayTimeIntervalType()), 0L)
checkEvaluation(cast(Literal.create("INTERVAL '1 2:03:04' DAY TO SECOND"),
DayTimeIntervalType()), 93784000000L)
checkEvaluation(cast(Literal.create("INTERVAL '1 03:04:00' DAY TO SECOND"),
DayTimeIntervalType()), 97440000000L)
checkEvaluation(cast(Literal.create("INTERVAL '1 03:04:00.0000' DAY TO SECOND"),
DayTimeIntervalType()), 97440000000L)
// checkEvaluation(cast(Literal.create("1 2:03:04"), DayTimeIntervalType()), 93784000000L)
checkEvaluation(cast(Literal.create("INTERVAL '-10 2:03:04' DAY TO SECOND"),
DayTimeIntervalType()), -871384000000L)
// checkEvaluation(cast(Literal.create("-10 2:03:04"), DayTimeIntervalType()), -871384000000L)
// checkEvaluation(cast(Literal.create("-106751991 04:00:54.775808"), DayTimeIntervalType()),
// Long.MinValue)
// checkEvaluation(cast(Literal.create("106751991 04:00:54.775807"), DayTimeIntervalType()),
// Long.MaxValue)
//
// Seq("-106751991 04:00:54.775808", "106751991 04:00:54.775807").foreach { interval =>
// val ansiInterval = s"INTERVAL '$interval' DAY TO SECOND"
// checkEvaluation(
// cast(cast(Literal.create(interval), DayTimeIntervalType()), StringType), ansiInterval)
// checkEvaluation(cast(cast(Literal.create(ansiInterval),
// DayTimeIntervalType()), StringType), ansiInterval)
// }
//
if (!isTryCast) {
Seq("INTERVAL '-106751991 04:00:54.775809' DAY TO SECOND",
"INTERVAL '106751991 04:00:54.775808' DAY TO SECOND").foreach { interval =>
val e = intercept[ArithmeticException] {
cast(Literal.create(interval), DayTimeIntervalType()).eval()
}.getMessage
assert(e.contains("long overflow"))
}
}
Seq(Byte.MaxValue, Short.MaxValue, Int.MaxValue, Long.MaxValue, Long.MinValue + 1,
Long.MinValue).foreach { duration =>
val interval = Literal.create(
Duration.of(duration, ChronoUnit.MICROS),
DayTimeIntervalType())
checkEvaluation(cast(cast(interval, StringType), DayTimeIntervalType()), duration)
}
}
test("SPARK-35735: Take into account day-time interval fields in cast2") {
def typeName(dataType: DayTimeIntervalType): String = {
if (dataType.startField == dataType.endField) {
DayTimeIntervalType.fieldToString(dataType.startField).toUpperCase(Locale.ROOT)
} else {
s"${DayTimeIntervalType.fieldToString(dataType.startField)} TO " +
s"${DayTimeIntervalType.fieldToString(dataType.endField)}".toUpperCase(Locale.ROOT)
}
}
Seq(("1", DayTimeIntervalType(DAY, DAY), (86400) * MICROS_PER_SECOND),
("-1", DayTimeIntervalType(DAY, DAY), -(86400) * MICROS_PER_SECOND),
("1 01", DayTimeIntervalType(DAY, HOUR), (86400 + 3600) * MICROS_PER_SECOND),
("-1 01", DayTimeIntervalType(DAY, HOUR), -(86400 + 3600) * MICROS_PER_SECOND),
("1 01:01", DayTimeIntervalType(DAY, MINUTE), (86400 + 3600 + 60) * MICROS_PER_SECOND),
("-1 01:01", DayTimeIntervalType(DAY, MINUTE), -(86400 + 3600 + 60) * MICROS_PER_SECOND),
("1 01:01:01.12345", DayTimeIntervalType(DAY, SECOND),
((86400 + 3600 + 60 + 1.12345) * MICROS_PER_SECOND).toLong),
("-1 01:01:01.12345", DayTimeIntervalType(DAY, SECOND),
(-(86400 + 3600 + 60 + 1.12345) * MICROS_PER_SECOND).toLong),
("01", DayTimeIntervalType(HOUR, HOUR), (3600) * MICROS_PER_SECOND),
("-01", DayTimeIntervalType(HOUR, HOUR), -(3600) * MICROS_PER_SECOND),
("01:01", DayTimeIntervalType(HOUR, MINUTE), (3600 + 60) * MICROS_PER_SECOND),
("-01:01", DayTimeIntervalType(HOUR, MINUTE), -(3600 + 60) * MICROS_PER_SECOND),
("01:01:01.12345", DayTimeIntervalType(HOUR, SECOND),
((3600 + 60 + 1.12345) * MICROS_PER_SECOND).toLong),
("-01:01:01.12345", DayTimeIntervalType(HOUR, SECOND),
(-(3600 + 60 + 1.12345) * MICROS_PER_SECOND).toLong),
("01", DayTimeIntervalType(MINUTE, MINUTE), (60) * MICROS_PER_SECOND),
("-01", DayTimeIntervalType(MINUTE, MINUTE), -(60) * MICROS_PER_SECOND),
("01:01", DayTimeIntervalType(MINUTE, SECOND), ((60 + 1) * MICROS_PER_SECOND)),
("01:01.12345", DayTimeIntervalType(MINUTE, SECOND),
((60 + 1.12345) * MICROS_PER_SECOND).toLong),
("-01:01.12345", DayTimeIntervalType(MINUTE, SECOND),
(-(60 + 1.12345) * MICROS_PER_SECOND).toLong),
("01.12345", DayTimeIntervalType(SECOND, SECOND), ((1.12345) * MICROS_PER_SECOND).toLong),
("-01.12345", DayTimeIntervalType(SECOND, SECOND), (-(1.12345) * MICROS_PER_SECOND).toLong))
.foreach { case (str, dataType, dt) =>
// checkEvaluation(cast(Literal.create(str), dataType), dt)
checkEvaluation(
cast(Literal.create(s"INTERVAL '$str' ${typeName(dataType)}"), dataType), dt)
checkEvaluation(
cast(Literal.create(s"INTERVAL -'$str' ${typeName(dataType)}"), dataType), -dt)
}
// Check max value
Seq(("INTERVAL '106751991' DAY", DayTimeIntervalType(DAY), 106751991L * MICROS_PER_DAY),
("INTERVAL '106751991 04' DAY TO HOUR", DayTimeIntervalType(DAY, HOUR), 9223372036800000000L),
("INTERVAL '106751991 04:00' DAY TO MINUTE",
DayTimeIntervalType(DAY, MINUTE), 9223372036800000000L),
("INTERVAL '106751991 04:00:54.775807' DAY TO SECOND", DayTimeIntervalType(), Long.MaxValue),
("INTERVAL '2562047788' HOUR", DayTimeIntervalType(HOUR), 9223372036800000000L),
("INTERVAL '2562047788:00' HOUR TO MINUTE",
DayTimeIntervalType(HOUR, MINUTE), 9223372036800000000L),
("INTERVAL '2562047788:00:54.775807' HOUR TO SECOND",
DayTimeIntervalType(HOUR, SECOND), Long.MaxValue),
("INTERVAL '153722867280' MINUTE", DayTimeIntervalType(MINUTE), 9223372036800000000L),
("INTERVAL '153722867280:54.775807' MINUTE TO SECOND",
DayTimeIntervalType(MINUTE, SECOND), Long.MaxValue),
("INTERVAL '9223372036854.775807' SECOND", DayTimeIntervalType(SECOND), Long.MaxValue))
.foreach { case (interval, dataType, dt) =>
checkEvaluation(cast(Literal.create(interval), dataType), dt)
checkEvaluation(cast(Literal.create(interval.toLowerCase(Locale.ROOT)), dataType), dt)
}
Seq(("INTERVAL '-106751991' DAY", DayTimeIntervalType(DAY), -106751991L * MICROS_PER_DAY),
("INTERVAL '-106751991 04' DAY TO HOUR",
DayTimeIntervalType(DAY, HOUR), -9223372036800000000L),
("INTERVAL '-106751991 04:00' DAY TO MINUTE",
DayTimeIntervalType(DAY, MINUTE), -9223372036800000000L),
("INTERVAL '-106751991 04:00:54.775808' DAY TO SECOND", DayTimeIntervalType(), Long.MinValue),
("INTERVAL '-2562047788' HOUR", DayTimeIntervalType(HOUR), -9223372036800000000L),
("INTERVAL '-2562047788:00' HOUR TO MINUTE",
DayTimeIntervalType(HOUR, MINUTE), -9223372036800000000L),
("INTERVAL '-2562047788:00:54.775808' HOUR TO SECOND",
DayTimeIntervalType(HOUR, SECOND), Long.MinValue),
("INTERVAL '-153722867280' MINUTE", DayTimeIntervalType(MINUTE), -9223372036800000000L),
("INTERVAL '-153722867280:54.775808' MINUTE TO SECOND",
DayTimeIntervalType(MINUTE, SECOND), Long.MinValue),
("INTERVAL '-9223372036854.775808' SECOND", DayTimeIntervalType(SECOND), Long.MinValue))
.foreach { case (interval, dataType, dt) =>
checkEvaluation(cast(Literal.create(interval), dataType), dt)
}
if (!isTryCast) {
Seq(
("INTERVAL '1 01:01:01.12345' DAY TO SECOND", DayTimeIntervalType(DAY, HOUR)),
("INTERVAL '1 01:01:01.12345' DAY TO HOUR", DayTimeIntervalType(DAY, SECOND)),
("INTERVAL '1 01:01:01.12345' DAY TO MINUTE", DayTimeIntervalType(DAY, MINUTE)),
("1 01:01:01.12345", DayTimeIntervalType(DAY, DAY)),
("1 01:01:01.12345", DayTimeIntervalType(DAY, HOUR)),
("1 01:01:01.12345", DayTimeIntervalType(DAY, MINUTE)),
("INTERVAL '01:01:01.12345' HOUR TO SECOND", DayTimeIntervalType(DAY, HOUR)),
("INTERVAL '01:01:01.12345' HOUR TO HOUR", DayTimeIntervalType(DAY, SECOND)),
("INTERVAL '01:01:01.12345' HOUR TO MINUTE", DayTimeIntervalType(DAY, MINUTE)),
("01:01:01.12345", DayTimeIntervalType(DAY, DAY)),
("01:01:01.12345", DayTimeIntervalType(HOUR, HOUR)),
("01:01:01.12345", DayTimeIntervalType(DAY, MINUTE)),
("INTERVAL '1.23' DAY", DayTimeIntervalType(DAY)),
("INTERVAL '1.23' HOUR", DayTimeIntervalType(HOUR)),
("INTERVAL '1.23' MINUTE", DayTimeIntervalType(MINUTE)),
("INTERVAL '1.23' SECOND", DayTimeIntervalType(MINUTE)),
("1.23", DayTimeIntervalType(DAY)),
("1.23", DayTimeIntervalType(HOUR)),
("1.23", DayTimeIntervalType(MINUTE)),
("1.23", DayTimeIntervalType(MINUTE)))
.foreach { case (interval, dataType) =>
val e = intercept[IllegalArgumentException] {
cast(Literal.create(interval), dataType).eval()
}.getMessage
assert(e.contains(s"Interval string does not match day-time format of " +
s"${IntervalUtils.supportedFormat((dataType.startField, dataType.endField))
.map(format => s"`$format`").mkString(", ")} " +
s"when cast to ${dataType.typeName}: $interval, " +
s"set ${SQLConf.LEGACY_FROM_DAYTIME_STRING.key} to true " +
"to restore the behavior before Spark 3.0."))
}
// Check first field outof bound
Seq(("INTERVAL '1067519911' DAY", DayTimeIntervalType(DAY)),
("INTERVAL '10675199111 04' DAY TO HOUR", DayTimeIntervalType(DAY, HOUR)),
("INTERVAL '1067519911 04:00' DAY TO MINUTE", DayTimeIntervalType(DAY, MINUTE)),
("INTERVAL '1067519911 04:00:54.775807' DAY TO SECOND", DayTimeIntervalType()),
("INTERVAL '25620477881' HOUR", DayTimeIntervalType(HOUR)),
("INTERVAL '25620477881:00' HOUR TO MINUTE", DayTimeIntervalType(HOUR, MINUTE)),
("INTERVAL '25620477881:00:54.775807' HOUR TO SECOND", DayTimeIntervalType(HOUR, SECOND)),
("INTERVAL '1537228672801' MINUTE", DayTimeIntervalType(MINUTE)),
("INTERVAL '1537228672801:54.7757' MINUTE TO SECOND", DayTimeIntervalType(MINUTE, SECOND)),
("INTERVAL '92233720368541.775807' SECOND", DayTimeIntervalType(SECOND)))
.foreach { case (interval, dataType) =>
val e = intercept[IllegalArgumentException] {
cast(Literal.create(interval), dataType).eval()
}.getMessage
assert(e.contains(s"Interval string does not match day-time format of " +
s"${IntervalUtils.supportedFormat((dataType.startField, dataType.endField))
.map(format => s"`$format`").mkString(", ")} " +
s"when cast to ${dataType.typeName}: $interval, " +
s"set ${SQLConf.LEGACY_FROM_DAYTIME_STRING.key} to true " +
"to restore the behavior before Spark 3.0."))
}
}
}
mattahrens
Is your feature request related to a problem? Please describe. Spark UT case
Cast string to day-time intervalandTake into account day-time interval fields in castfailed because we are not supportshort modeof DayTimeIntervalType when cast string to daytime.Uncomment the
Cast string to day-time intervalorTake into account day-time interval fields in castin RapidsTestSettings.scala, then runRapidsCastSuite:got:
Describe the solution you'd like
We will check the subtype in DayTimeIntervalType and find a regex pattern in GpuIntervalUtilsBase , then extract the input data with the pattern. We can updated those pattern so it can also match data in short mode.
Describe alternatives you've considered If we are not plan to support it, at least we need to note we do not support short mode of DayTimeIntervalType in compatibility doc.