search

NVIDIA / spark-rapids

Spark RAPIDS plugin - accelerate Apache Spark with GPUs
https://nvidia.github.io/spark-rapids
Apache License 2.0
783 stars 228 forks source link

[FEA] Better corner case testing for casting #1764

Open revans2 opened 3 years ago

revans2 commented 3 years ago

From https://github.com/rapidsai/cudf/issues/5225 it is obvious that there are some corner cases that cause issues with float/double tests. Some of these are being fixed as a part of https://github.com/rapidsai/cudf/pull/7410 but our tests are really inadequate despite fuzzing. Really the issue is that we are only testing with 100 values and that the values themselves will never produce invalid values that overflow. They also will never in practice hit a Double.MaxValue or Double.MinValue. It would be nice to have some special tests to augment these.

sameerz commented 3 years ago

Will leave open until rapidsai/cudf#7410 issue is fixed so we can add the remaining test cases.