NVIDIA / spark-rapids

Spark RAPIDS plugin - accelerate Apache Spark with GPUs
https://nvidia.github.io/spark-rapids
Apache License 2.0
822 stars 235 forks source link

[BUG] Unit test failures in Spark 3.2 shim build #3376

Closed gerashegalov closed 3 years ago

gerashegalov commented 3 years ago

Describe the bug Umbrella issue to fix unit tests in the 3.2 shim

Steps/Code to reproduce bug

$ mvn clean package -Dbuildver=320 -Dskip  

Expected behavior no unit test failures

Environment details (please complete the following information) local

Additional context

3323

Tasks:

HashAggregatesSuite

Fixed by https://github.com/NVIDIA/spark-rapids/pull/3403

CastOpSuite

See https://github.com/NVIDIA/spark-rapids/issues/3382 for more detail.

Fixed by https://github.com/NVIDIA/spark-rapids/pull/3439 and https://github.com/NVIDIA/spark-rapids/pull/3531

ExpandExecSuite

Fixed by https://github.com/NVIDIA/spark-rapids/pull/3403

WindowFunctionSuite

Filed as https://github.com/NVIDIA/spark-rapids/issues/3415

Fixed by https://github.com/NVIDIA/spark-rapids/pull/3547

ParquetWriterSuite

These tests were fixed by https://github.com/NVIDIA/spark-rapids/pull/3377

CostBasedOptimizerSuite

These tests were fixed by https://github.com/NVIDIA/spark-rapids/pull/3377 and SPARK-36666

These tests need updating and have been ignored for now. There is a follow-on issue https://github.com/NVIDIA/spark-rapids/issues/3526 to update them when we resume work on CBO.

AdaptiveQueryExecSuite

These tests were fixed by https://github.com/NVIDIA/spark-rapids/pull/3377 and SPARK-36666

KnownNotNullSuite

Fixed by https://github.com/NVIDIA/spark-rapids/pull/3457

AnsiCastOpSuite

These tests were fixed by https://github.com/NVIDIA/spark-rapids/pull/3377

ParseDateTimeSuite

See https://github.com/NVIDIA/spark-rapids/issues/3383 for more detail. fixed by https://github.com/NVIDIA/spark-rapids/pull/3439

ScalarSubquerySuite

Failures due to https://github.com/NVIDIA/spark-rapids/issues/3400 (canonicalizationMatchesCpu=true != canonicalizationMatchesGpu=false)

andygrove commented 3 years ago

I am looking at the AnsiCastOpSuite failures with the pattern WITH DECIMALS: Write _ to _.

andygrove commented 3 years ago

I also started looking at CastOpSuite and filed a separate issue since this looks like it could be quite involved. https://github.com/NVIDIA/spark-rapids/issues/3382

andygrove commented 3 years ago

I filed https://github.com/NVIDIA/spark-rapids/issues/3383 for ParseDateTimeSuite failures

tgravescs commented 3 years ago

cast ops is fixed by 3531 and no other unit tests failures currently

tgravescs commented 3 years ago

3.2 unit tests all pass now