search

NVIDIAGameWorks / NVIDIAImageScaling

NVIDIA Image Scaling SDK
MIT License
506 stars 59 forks source link

Dealing with some artifacts #6

Open trsh opened 2 years ago

trsh commented 2 years ago

Dear nvidia, do you have any idea or advice, on what would cause the ugly line on the front box?

2022-11-07_103847

abernalnv commented 2 years ago

can you try NIS_CLAMP_OUTPUT = 1 in your defines? Also try to use a bit less sharpness Are you using NIS with HDR?

trsh commented 2 years ago

can you try NIS_CLAMP_OUTPUT = 1 in your defines? Also try to use a bit less sharpness Are you using NIS with HDR?

NIS_CLAMP_OUTPUT did not make a difference. HDR is = NISHDRMode::None. Sharpness can be 0, and same line.

trsh commented 2 years ago

2022-11-07_105755 Sharpness 0 + NIS_CLAMP_OUTPUT

abernalnv commented 2 years ago

What is the scale ratio? Do you have an image that we can use for debugging?

trsh commented 2 years ago 
in_x = 640
in_y = 360
out_x = 1280
out_y = 720

This should be the texture, that is upscaled

before_upsc

abernalnv commented 2 years ago

@trsh, Thank you Janis. We'll take a look.

trsh commented 1 year ago

Anything new around this?

abernalnv commented 1 year ago

@trsh. We have not being able to repro the strong artifacts on the lines, but we observed some overshooting on the edges specially with large sharpness values. The image is already very sharp and applying sharpening on top can result on overshooting. We're investigating using a different detection ratio as well as an attenuated LTI function that might help with this specific case.

trsh commented 1 year ago

Strange that you were not able to reproduce. Then it should be something off with my setup!?