search

NVIDIAGameWorks / PhysX-3.4

NVIDIA PhysX SDK 3.4
https://www.nvidia.com/
2.35k stars 277 forks source link

Missing explicit braces for older compiler versions of gcc (linux32) #15

Closed dschmid2 closed 7 years ago

dschmid2 commented 7 years ago

I use gcc gcc (SUSE Linux) 4.3.2 [gcc-4_3-branch revision 141291] and i have the following issues due to missing braces. They just have to be added.

./../../LowLevelAABB/src/BpBroadPhaseMBP.cpp:1898: error: suggest a space before ‘;’ or explicit braces around empty body in ‘while’ statement [-Wempty-body]

./../../LowLevelAABB/src/BpBroadPhaseSapAux.cpp:746: error: suggest a space before ‘;’ or explicit braces around empty body in ‘while’ statement [-Wempty-body]

./../../LowLevelAABB/src/BpSimpleAABBManager.cpp:1206: error: suggest a space before ‘;’ or explicit braces around empty body in ‘while’ statement [-Wempty-body]

./../../LowLevelDynamics/src/DyConstraintPartition.cpp:443: error: suggest a space before ‘;’ or explicit braces around empty body in ‘for’ statement [-Wempty-body]

./../../LowLevelDynamics/src/DySolverControl.h:47: error: suggest a space before ‘;’ or explicit braces around empty body in ‘while’ statement [-Wempty-body] ./../../LowLevelDynamics/src/DySolverControl.h:60: error: suggest a space before ‘;’ or explicit braces around empty body in ‘while’ statement [-Wempty-body] ./../../LowLevelDynamics/src/DySolverControl.h:61: error: suggest a space before ‘;’ or explicit braces around empty body in ‘while’ statement [-Wempty-body]

./../../LowLevelDynamics/src/DyDynamics.cpp:2447: error: suggest a space before ‘;’ or explicit braces around empty body in ‘while’ statement [-Wempty-body] ./../../LowLevelDynamics/src/DyDynamics.cpp:2869: error: suggest a space before ‘;’ or explicit braces around empty body in ‘for’ statement [-Wempty-body]

./../../PhysXExtensions/src/serialization/SnSerialization.cpp:325: error: suggest a space before ‘;’ or explicit braces around empty body in ‘while’ statement [-Wempty-body]

./../../PhysXExtensions/src/serialization/Xml/SnRepXUpgrader.cpp:62: error: suggest a space before ‘;’ or explicit braces around empty body in ‘for’ statement [-Wempty-body]

./../../Common/src/CmBoxPruning.cpp:176: error: suggest a space before ‘;’ or explicit braces around empty body in ‘while’ statement [-Wempty-body]

sschirm commented 7 years ago

Sorry, we don't really maintain the gcc build actively anymore. We moved on to clang, which has a pretty high standard for warnings.