search

NVIDIAGameWorks / PhysX-3.4

NVIDIA PhysX SDK 3.4
https://www.nvidia.com/
2.35k stars 274 forks source link

PsWindowsSocket VS 2017 warning C2220 #37

Closed rextimmy closed 7 years ago

rextimmy commented 7 years ago

mPort is initialised before mHost ... https://github.com/NVIDIAGameWorks/PhysX-3.4/blob/master/PxShared/src/foundation/src/windows/PsWindowsSocket.cpp#L98-L99. These need swapping around as mHost is declared before mPort ( https://github.com/NVIDIAGameWorks/PhysX-3.4/blob/master/PxShared/src/foundation/src/windows/PsWindowsSocket.cpp#L87-L88 ) and warnings are treated as errors with the current setup on visual studio.

AlesBorovicka commented 7 years ago

Thanks, we have it fixed on latest trunk, but please note that VS2017 is not supported atm, there is a compiler bug preventing the usage. See: https://developercommunity.visualstudio.com/content/problem/66047/possible-compiler-bug.html

rextimmy commented 7 years ago

Oh thanks for pointing that out. No worries if you guys have internally fixed the above in your codebase than i'll close the issue