Can't get NRD to build

[Nielsbishere]

Hi devs from NV,

I've tried to get it to build for a bit, but no luck yet. I currently have these versions installed:

Latest Vulkan SDK 1.2.170.0 Latest Windows 20H2 19042.844 Latest Visual Studio 2017 15.9.33 and 2019 16.9.0 (neither work) The latest version of MBulli.SmartCommandlineArguments. (Irrelevant for building I think) Latest version of Nvidia driver (461.72)

Both ways listed in the README don't seem to work, neither manually building via visual studio nor automatically via MSBuild (Via the second command).

1-Deploy & 2-Build (Entered 2: vs2019, but 1 vs2017 also doesn't work)

"D:\programming\work\RayTracingDenoiser\_Compiler\vs2019\SANDBOX.sln" (Build target) (1) ->
"D:\programming\work\RayTracingDenoiser\_Compiler\vs2019\09_RayTracing_NRD\09_RayTracing_NRD.vcxproj" (default target)
(2) ->
"D:\programming\work\RayTracingDenoiser\_Compiler\vs2019\SampleBase\SampleBase.vcxproj" (default target) (8) ->
"D:\programming\work\RayTracingDenoiser\_Compiler\vs2019\CompileShaders\CompileShaders.vcxproj" (default target) (9) ->
(PostBuildEvent target) ->
  EXEC : error : failed to wait for process: 258 ('CompileShader.bat cs "D:\programming\work\RayTracingDenoiser\NRD\Sha
ders\REBLUR_DiffuseSpecular_PreBlur.cs.hlsl" "D:\programming\work\RayTracingDenoiser\_Data\Shaders\REBLUR_DiffuseSpecul
ar_PreBlur.cs" "D:\programming\work\RayTracingDenoiser\_Build\Shaders\REBLUR_DiffuseSpecular_PreBlur.cs"') [D:\programm
ing\work\RayTracingDenoiser\_Compiler\vs2019\CompileShaders\CompileShaders.vcxproj]
  EXEC : error : the process is still alive: 1 [D:\programming\work\RayTracingDenoiser\_Compiler\vs2019\CompileShaders\
CompileShaders.vcxproj]
  EXEC : error : failed to execute the command line: 'CompileShader.bat cs "D:\programming\work\RayTracingDenoiser\NRD\
Shaders\REBLUR_DiffuseSpecular_PreBlur.cs.hlsl" "D:\programming\work\RayTracingDenoiser\_Data\Shaders\REBLUR_DiffuseSpe
cular_PreBlur.cs" "D:\programming\work\RayTracingDenoiser\_Build\Shaders\REBLUR_DiffuseSpecular_PreBlur.cs"' (result: 2
59) [D:\programming\work\RayTracingDenoiser\_Compiler\vs2019\CompileShaders\CompileShaders.vcxproj]
  EXEC : error : failed to wait for process: 258 ('CompileShader.bat cs "D:\programming\work\RayTracingDenoiser\NRD\Sha
ders\REBLUR_Diffuse_PostBlur.cs.hlsl" "D:\programming\work\RayTracingDenoiser\_Data\Shaders\REBLUR_Diffuse_PostBlur.cs"
 "D:\programming\work\RayTracingDenoiser\_Build\Shaders\REBLUR_Diffuse_PostBlur.cs"') [D:\programming\work\RayTracingDe
noiser\_Compiler\vs2019\CompileShaders\CompileShaders.vcxproj]
  EXEC : error : failed to wait for process: 258 ('CompileShader.bat cs "D:\programming\work\RayTracingDenoiser\NRD\Sha
ders\SVGF_FilterMoments.cs.hlsl" "D:\programming\work\RayTracingDenoiser\_Data\Shaders\SVGF_FilterMoments.cs" "D:\progr
amming\work\RayTracingDenoiser\_Build\Shaders\SVGF_FilterMoments.cs"') [D:\programming\work\RayTracingDenoiser\_Compile
r\vs2019\CompileShaders\CompileShaders.vcxproj]
  EXEC : error : the process is still alive: 1 [D:\programming\work\RayTracingDenoiser\_Compiler\vs2019\CompileShaders\
CompileShaders.vcxproj]
  EXEC : error : the process is still alive: 1 [D:\programming\work\RayTracingDenoiser\_Compiler\vs2019\CompileShaders\
CompileShaders.vcxproj]
  EXEC : error : failed to execute the command line: 'CompileShader.bat cs "D:\programming\work\RayTracingDenoiser\NRD\
Shaders\SVGF_FilterMoments.cs.hlsl" "D:\programming\work\RayTracingDenoiser\_Data\Shaders\SVGF_FilterMoments.cs" "D:\pr
ogramming\work\RayTracingDenoiser\_Build\Shaders\SVGF_FilterMoments.cs"' (result: 259) [D:\programming\work\RayTracingD
enoiser\_Compiler\vs2019\CompileShaders\CompileShaders.vcxproj]
  EXEC : error : failed to execute the command line: 'CompileShader.bat cs "D:\programming\work\RayTracingDenoiser\NRD\
Shaders\REBLUR_Diffuse_PostBlur.cs.hlsl" "D:\programming\work\RayTracingDenoiser\_Data\Shaders\REBLUR_Diffuse_PostBlur.
cs" "D:\programming\work\RayTracingDenoiser\_Build\Shaders\REBLUR_Diffuse_PostBlur.cs"' (result: 259) [D:\programming\w
ork\RayTracingDenoiser\_Compiler\vs2019\CompileShaders\CompileShaders.vcxproj]
  D:\programs\vs\ide\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(155,5): error MSB3073: The command ""D:/prog
ramming/work/RayTracingDenoiser/_Build/vs2019/Bin/Release/CompileShaders.exe" [D:\programming\work\RayTracingDenoiser\_
Compiler\vs2019\CompileShaders\CompileShaders.vcxproj]
D:\programs\vs\ide\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(155,5): error MSB3073: :VCEnd" exited with cod
e 1. [D:\programming\work\RayTracingDenoiser\_Compiler\vs2019\CompileShaders\CompileShaders.vcxproj]

    0 Warning(s)
    10 Error(s)

I'd be interested in hearing if I maybe forgot to update/install something that wasn't listed in the README or if you know what's going on. I also tested f9067efe5c06671b932bcf22dfcb022be69f54a4, since the latest is listed as WIP; no luck unfortunately.

If it helps, my install locations aren't at the default locations, so maybe the shader compiler can't find the proper tools from spirv?

-Niels Brunekreef

[dzhdanNV]

my install locations aren't at the default locations

that's the reason. WIN SDK path is hard to detect in a batch file. CompileShader.bat uses a default path (hardcoded in the script).

[Nielsbishere]

Cool, so I can change it there? Maybe that could be added as an optional install step too, for future reference

[dzhdanNV]

Thanks. Your addition to README.md will be added to the next version.