search

NVIDIAGameWorks / RayTracingDenoiser

NVIDIA Ray Tracing Denoiser
Other
504 stars 46 forks source link

Fix luminance formula being base on BT.601 instead of BT.709 #57

Closed Filoppi closed 1 year ago

Filoppi commented 1 year ago

This is a common mistake, as google research often come up with the BT.601 values instead of ~"0.2126729 0.7151522 0.072175".

I'm assuming the denoiser isn't using BT.601 internally, but I highly doubt it is :).

Source: https://en.wikipedia.org/wiki/Rec._709#Luma_coefficients http://www.glennchan.info/articles/technical/rec709rec601/rec709rec601.html https://stackoverflow.com/a/596241

dzhdanNV commented 1 year ago

@Filoppi Hey! Thanks. I tend to agree with you. But I will cancel this PR because the sum of your coefficients is > 1.0. I will fix coefficients in my local version and update GitHub early next week. Coefficients will be 0.2126, 0.7152, 0.0722.