search

NVIDIAGameWorks / RayTracingDenoiser

NVIDIA Ray Tracing Denoiser
Other
504 stars 46 forks source link

Fix luminance formula being base on BT.601 instead of BT.709 #58

Closed Filoppi closed 1 year ago

Filoppi commented 1 year ago

Corrected the formula, I must have made a mistake when writing it down manually at some point. These values 0.2126729 0.7151521 0.0721750 are commonly used, and should be more accurate than 0.2126, 0.7152, 0.0722. Though you can close this PR again if you want :).

I haven't really read the whole documentation of NRD, but it seems to work in a specific color space (Rec.709). I suppose the documentation specifies that?

dzhdanNV commented 1 year ago

I'm closing it again because you fixed front-end only. There is STL.hlsli which uses BT.601 inside NRD. In other words, your PR breaks internal logic.