Closed Nielsbishere closed 11 months ago
Should OUT_SHADOW_TRANSLUCENCY in the inputs also be IN_SHADOW_TRANSLUCENCY?
Thanks!
I fixed the comments in enum class Denoiser
:
enum class Denoiser : uint32_t
{
/*
IMPORTANT: IN_MV, IN_NORMAL_ROUGHNESS, IN_VIEWZ are used by any denoiser
These denoisers DON'T use:
REFERENCE - IN_MV, IN_NORMAL_ROUGHNESS, IN_VIEWZ
SPECULAR_DELTA_MV - IN_NORMAL_ROUGHNESS, IN_VIEWZ
*/
<removed IN_MV, IN_NORMAL_ROUGHNESS, IN_VIEWZ from other comments>
};
Should
OUT_SHADOW_TRANSLUCENCY
in the inputs also beIN_SHADOW_TRANSLUCENCY
?
No. To save memory SIGMA uses the output from the previous frame as the history buffer in the next frame. A recurrent thing.
It seems like if I execute sigma without motion vectors I get a crash because it is trying to get the texture of IN_MV even though the documentation in NRDDescs.h says:
I'm guessing this is just a mistake in the documentation? As generally you do want motion vectors for any kind of denoiser.