Closed ch45er closed 8 months ago
Would it be enough to use this?
if (MSVC AND NOT DEFINED CMAKE_MSVC_RUNTIME_LIBRARY)
set (CMAKE_MSVC_RUNTIME_LIBRARY "MultiThreaded$<$<CONFIG:Debug>:Debug>")
endif ()
Yes, that works for me.
Will be included in the next update.
Fixed in v4.4.0.
This one is related to #33.
The
CMAKE_MSVC_RUNTIME_LIBRARY
variable is set unconditionally in the CMake lists, which effectively prohibits passing it as a command line argument (since it gets overwritten in the script): https://github.com/NVIDIAGameWorks/RayTracingDenoiser/blob/067755e96c70d4122342c61a37124111715c4e57/CMakeLists.txt#L64-L66It would be better to provide a CMake
option
for this or additionally check ifCMAKE_MSVC_RUNTIME_LIBRARY
is unspecified at that point.