search

NVIDIAGameWorks / Streamline

Streamline Integration Framework
Other
377 stars 79 forks source link

Typo in PrecisionInfo ctor #25

Open QDanteQ opened 9 months ago

QDanteQ commented 9 months ago

include\sl.h(369,40): error : base class 'sl::BaseStructure' is uninitialized when used here to access 'sl::BaseStructure::structType' [-Werror,-Wuninitialized]

You might wanted to pass PrecisionInfo::s_structType instead of BaseStructure::structType in BaseStructure ctor

jake-nv commented 6 months ago

Thanks for reporting this!

Missed the cut-off for the upcoming release, but it will be in a later one.

jake-nv commented 3 months ago

We haven’t forgotten about this. This wasn’t in 2.4.10 because it was done after a re-org of sl.h that now can’t be cherry-picked into 2.4.x. It’ll go in with the next mass-integration (likely 2.5 or the equivalent).