Missing const for uint32_t* frameIndex in PFun_slGetNewFrameToken

NVIDIAGameWorks / Streamline

Streamline Integration Framework

Other

377 stars 79 forks source link

Missing const for uint32_t* frameIndex in PFun_slGetNewFrameToken #37

Open QDanteQ opened 5 months ago

QDanteQ commented 5 months ago

Hello, I guess you've missed const specifier for uint32_t* frameIndex. There's const in function declaration (down the file) and in implementation. https://github.com/NVIDIAGameWorks/Streamline/blob/7ac42e47c7dd55b5b6dd6176c0228048636541b2/include/sl.h#L660

jake-nv commented 5 months ago

Nice catch.

This won’t be in the upcoming release, but it will be in the one after.

jake-nv commented 3 months ago

We haven’t forgotten about this. This wasn’t in 2.4.10 because it was done after a re-org of sl.h that now can’t be cherry-picked into 2.4.x. It’ll go in with the next mass-integration (likely 2.5 or the equivalent).