search

NVIDIAGameWorks / Streamline

Streamline Integration Framework
Other
391 stars 83 forks source link

Missing sl::Result::eWarnOutOfVRAM in sl::getResultAsStr(Result v) #38

Closed QDanteQ closed 4 months ago

QDanteQ commented 6 months ago

https://github.com/NVIDIAGameWorks/Streamline/blob/7b94724d98ee6dccbf06def3ed89f18028647b35/include/sl_helpers.h#L52

QDanteQ commented 6 months ago

Also should SL_FAILED(res, sl::Result::eWarnOutOfVRAM) return false, since this is a warning?

jake-nv commented 6 months ago

Will get that added.

“Failed” is perhaps not the best name, but SL_SUCCEEDED == !SL_FAILED. With WarnOutIfVRAM everything is not “ok” we need you to do something.

QDanteQ commented 6 months ago

Thank you!

On Tue, Apr 16, 2024, 20:36 jake-nv @.***> wrote:

Will get that added.

“Failed” is perhaps not the best name, but SL_SUCCEEDED == !SL_FAILED. With WarnOutIfVRAM everything is not “ok” we need you to do something.

— Reply to this email directly, view it on GitHub https://github.com/NVIDIAGameWorks/Streamline/issues/38#issuecomment-2059599861, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARBGXF45SEGIWQ2PB7N2SCTY5VORTAVCNFSM6AAAAABGDS6DD2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJZGU4TSOBWGE . You are receiving this because you authored the thread.Message ID: @.***>