NVIDIAGameWorks / kaolin-wisp

NVIDIA Kaolin Wisp is a PyTorch library powered by NVIDIA Kaolin Core to work with neural fields (including NeRFs, NGLOD, instant-ngp and VQAD).
Other
1.45k stars 132 forks source link

Fix default bottom level renderers args from tracers #121

Closed orperel closed 1 year ago

orperel commented 1 year ago

The interactive renderer's Bottom Level Renderers: NeuralRadianceFieldPackedRenderer and NeuralSDFPackedRenderer used default fixed tracer args. This is assumption was wrong: both renderers are normally constructed from some tracer (usually this tracer is the one used for optimization). The correct method is taking arguments like num_steps from the tracer they duplicate for construction. A clarification for overriding those args have also been documented.

Signed-off-by: operel operel@nvidia.com