[#131] Fix skimage SSIM win_size error

NVIDIAGameWorks / kaolin-wisp

NVIDIA Kaolin Wisp is a PyTorch library powered by NVIDIA Kaolin Core to work with neural fields (including NeRFs, NGLOD, instant-ngp and VQAD).

Other

1.45k stars 133 forks source link

[#131] Fix skimage SSIM win_size error #133

Closed jaeheungs closed 1 year ago

jaeheungs commented 1 year ago

Addressing issue #131

Running the demos on the README leads to an error due to skimage thinking that the color channel for the images used for SSIM are part of the image dimension rather than channels. Maybe the tests have been run with a different version of skimage?

Running the demo script: python3 app/nerf/main_nerf.py --config ./app/nerf/configs/nerf_hash.yaml --dataset-path path/to/dataset/ --dataset-num-workers 4 works for me after this edit.

orperel commented 1 year ago

Hi @jaeheungs , confirmed - I finally hit this bug as well with a different skimage version. Re-running tests again now