NVIDIAGameWorks / kaolin-wisp

NVIDIA Kaolin Wisp is a PyTorch library powered by NVIDIA Kaolin Core to work with neural fields (including NeRFs, NGLOD, instant-ngp and VQAD).
Other
1.46k stars 131 forks source link

Fixing unexpected processing of iterate() of BaseTrainer #163

Closed barikata1984 closed 1 year ago

barikata1984 commented 1 year ago

Hi, thanks for developing such an amazing library. This is a PR to fix the unexpected behaviour of iterate(). Please refer to the following description. I hope this request will be approved.

Changes proposed in this PR

Reason for the proposal

The original iterate() calls step() before pre_training(), and post_training() before and after the last step().

Reference

BaseTrainer in the main branch