search

NVSL / linux-nova

NOVA is a log-structured file system designed for byte-addressable non-volatile memories, developed at the University of California, San Diego.
http://nvsl.ucsd.edu/index.php?path=projects/nova
Other
423 stars 118 forks source link

XFSTests generic/285: lseek misbehaves(?) in the presence of holes. #22

Closed stevenjswanson closed 7 years ago

stevenjswanson commented 7 years ago

This is probably related to #21.

This functions creates a file with a hole at the end, and checks the behavior of SEEK_HOLE

https://github.com/NVSL/xfstests/blob/master/src/seek_sanity_test.c#L160

It finds that pos != filsz, which it reported the presence of the hole and only seeked past the first two blocks.

This function https://github.com/NVSL/xfstests/blob/master/src/seek_sanity_test.c#L903

called from here:

https://github.com/NVSL/xfstests/blob/master/src/seek_sanity_test.c#L614

creates a file with the hole at the beginning and then tests SEEK_DATA, which ignores the hole and acts as if the space is allocated.

stevenjswanson commented 7 years ago

Fixed by adjusting xfstests. NVSL/xfstest@bb28a88b5772f97e073476131c2cfb6e8f676a96

resolves #21