Is static ```flags``` in ```nova_writeable``` reasonable?

NVSL / linux-nova

NOVA is a log-structured file system designed for byte-addressable non-volatile memories, developed at the University of California, San Diego.

http://nvsl.ucsd.edu/index.php?path=projects/nova

Other

421 stars 118 forks source link

Is static ```flags``` in ```nova_writeable``` reasonable? #96

Closed seekstar closed 3 years ago

seekstar commented 3 years ago

The static variable flags is shared among the cpus. So if two cpus call local_irq_save(flags) in the same time, one CPU will overwrite flags the other CPU wrote. If I am wrong please correct me.

Andiry commented 3 years ago

Guess you are right: I don't see why the flags is declared static.