Unable to set the subprotocol on connection

NVentimiglia / WebSocket.Portable

C# Portable WebSocket Client Library (Rfc 6455). Works with Xamarin.

Apache License 2.0

11 stars 2 forks source link

Unable to set the subprotocol on connection #4

Closed jonclare closed 8 years ago

jonclare commented 8 years ago

The WebSocketResponseHandshake class provides the ability to set the subprotocol, but a default handshake is created during the WebSocketClientBase.OpenAsync method and as far as I can tell it's not possible to set the subprotocol when opening the connection.

This is needed to connect to certain servers.

NVentimiglia commented 8 years ago

Thanks for the commit !

jonclare commented 8 years ago

No worries. I've been doing some work recently on getting WampSharp working with a PCL websocket library, and this change was needed.

If you're able to do a release at some point with the sub protocol changes that would greatly assist me as I don't want to put the stuff from my fork onto NuGet and create a potentially confusing alternative to your library!