NVlabs / FPSci

Aim Training Experiments
Other
70 stars 23 forks source link

Add new users #245

Closed bboudaoud-nv closed 4 years ago

bboudaoud-nv commented 4 years ago

This branch adds support for adding new users from within the application. As it a result it also adds:

Once new users are created the user can be directed to setup their mouse sensitivity and/or reticle (depending on what is allowed for the experiment) from the normal user menu.

bboudaoud-nv commented 4 years ago

Currently the DPI and reticle index are borrowed from the last user in the users list. We could implement additional configuration parameters for the high level user table that provide defaults here.

jspjutNV commented 4 years ago

I notice that the shift key still fires at the dummy target if it's present. This makes typing capital letters in a user name a little annoying, but not show stopping. I'll probably merge this if it's the only problem, and open a separate issue to fix the problem.

jspjutNV commented 4 years ago

Actually, I fixed the dummy shot problem, continuing my review.

jspjutNV commented 4 years ago

I've noticed a regression where this crashes when a selected user has completed all sessions when selectedSession() is called in GuiElements.h. This appears to be related to the change adding .text() to the return value.

I suspect that the logic in the function may have changed incorrectly since m_ddCurrSessIdx appears to be -1 in this case, and the >= comparison means the empty case will never be caught.